Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hw,spi_host,rtl] Remove configopts multi register #25727

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Dec 20, 2024

With a single configopts register, the register layout does not change when the user changes the NumCS parameter. Firmware, however needs to set up the config register ahead of a new transfer, but only when switching to a different device.

@Razer6 Razer6 requested a review from a team as a code owner December 20, 2024 13:35
@Razer6 Razer6 requested review from rswarbrick, a-will and andreaskurth and removed request for a team December 20, 2024 13:35
Copy link
Contributor

@a-will a-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! (modulo the little fixups that remain to get CI to pass)

@Razer6 Razer6 force-pushed the spihost-single-configopts branch from a9be9a9 to 80f1a94 Compare December 20, 2024 17:39
@Razer6 Razer6 requested a review from a team as a code owner December 20, 2024 17:39
@Razer6 Razer6 requested review from pamaury and removed request for a team December 20, 2024 17:39
@Razer6 Razer6 force-pushed the spihost-single-configopts branch 6 times, most recently from c4b762d to 0143409 Compare December 20, 2024 19:41
@Razer6 Razer6 force-pushed the spihost-single-configopts branch 2 times, most recently from 387d6a4 to 91571d2 Compare December 21, 2024 08:37
@Razer6 Razer6 force-pushed the spihost-single-configopts branch from 91571d2 to 2c0fa05 Compare December 21, 2024 09:23
@andreaskurth
Copy link
Contributor

CHANGE AUTHORIZED: hw/ip/spi_host/data/spi_host.hjson
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host.sv
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host_reg_pkg.sv
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host_reg_top.sv

Backward-incompatible changes aligned with current development stages for v3.0.0

@Razer6 Razer6 force-pushed the spihost-single-configopts branch 5 times, most recently from 1b614e2 to 3ef337b Compare December 21, 2024 14:53
FW needs to set up configopts before starting a transfer

Signed-off-by: Robert Schilling <[email protected]>
@Razer6 Razer6 force-pushed the spihost-single-configopts branch from 3ef337b to 739023a Compare December 21, 2024 15:46
@andreaskurth andreaskurth merged commit 6ee0cf0 into lowRISC:master Dec 23, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants